netdev - Re: [patch 02/21] drivers/net/3c501.c: replace init_module&cleanup_module with module_init&module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080328150710.6a664440.akpm@linux-foundation.org>
Date:	Fri, 28 Mar 2008 15:07:10 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	jeff@...zik.org, netdev@...r.kernel.org, jkschind@...il.com
Subject: Re: [patch 02/21] drivers/net/3c501.c: replace
 init_module&cleanup_module with module_init&module_exit

On Fri, 28 Mar 2008 21:47:55 +0000
Al Viro <viro@...IV.linux.org.uk> wrote:

> On Fri, Mar 28, 2008 at 02:41:16PM -0700, akpm@...ux-foundation.org wrote:
> 
> > Replace init_module and cleanup_module with static functions and
> > module_init/module_exit.
> 
> Would the esteemed sir bother to build the resulting tree with drivers
> in question non-modular?
> 
> Damnit, people, try to think for a minute.  If these functions were
> not called directly in non-modular case, the driver would not work
> built-in.  Which is not apriori impossible, but might warrant some
> further investigation.  Use of grep, for starters...
> 

well...  The probe functions are still called, only they're now called at
initcall-time as well as from the infamous Space.c.

So I guess these patches should at least have removed the calls from
Space.c tables, but iirc things aren't as simple as that.  I don't remember
why.

> IOW, please unapply the patches in question.

always happy to do that.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html