netdev - Re: [patch 20/21] forcedeth: fix locking bug with netconsole

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080328164209.e8b723d8.akpm@linux-foundation.org>
Date:	Fri, 28 Mar 2008 16:42:09 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	mingo@...e.hu, aabdulla@...dia.com
Subject: Re: [patch 20/21] forcedeth: fix locking bug with netconsole

On Fri, 28 Mar 2008 18:48:46 -0400 Jeff Garzik <jeff@...zik.org> wrote:

> David Miller wrote:
> > From: akpm@...ux-foundation.org
> > Date: Fri, 28 Mar 2008 14:41:30 -0700
> > 
> >> From: Ingo Molnar <mingo@...e.hu>
> >>
> >> While using netconsole on forcedeth, lockdep noticed the following locking
> >> bug:
> > 
> > Please do not mix device driver changes with core networking
> > changes.
> 
> FWIW my plan was to snip the net/* stuff and only apply the forcedeth 
> portion.
> 
> (leaving <whomever> to pick up the pieces, should they so desire)
> 

Just drop 'em completely I'd say.

otoh, drivers do seem a bit flakey in the netpoll-support area, so a bit of
extra debug wouldn't hurt.  But checking irqs_disabled() either side of a
udelay() was a bit paranoid ;)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html