netdev - Re: [PATCH] SCTP: Remove an useless parameter from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080328025404.GO14945@ghostprotocols.net>
Date:	Thu, 27 Mar 2008 23:54:04 -0300
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Gui Jianfeng <guijianfeng@...fujitsu.com>
Cc:	Arnaldo Carvalho de Melo <acme@...hat.com>,
	vladislav <vladislav.yasevich@...com>,
	netdev <netdev@...r.kernel.org>,
	lksctp-dev <lksctp-developers@...ts.sourceforge.net>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH] SCTP: Remove an useless parameter from

Em Fri, Mar 28, 2008 at 10:25:18AM +0800, Gui Jianfeng escreveu:
> Arnaldo Carvalho de Melo wrote:
> > Em Fri, Mar 28, 2008 at 09:52:22AM +0800, Gui Jianfeng escreveu:
> >> Vlad,
> >> There is an useless parameter in sctp_cmd_hb_timer_update,
> >> remove it.
> >>
> >> Signed-off-by: Gui Jianfeng <guijianfeng@...fujitsu.com>
> >> ---
> >>  net/sctp/sm_sideeffect.c |    3 +--
> >>  1 files changed, 1 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c
> >> index 28eb38e..5daeab5 100644
> >> --- a/net/sctp/sm_sideeffect.c
> >> +++ b/net/sctp/sm_sideeffect.c
> >> @@ -593,7 +593,6 @@ static void sctp_cmd_t3_rtx_timers_stop(sctp_cmd_seq_t *cmds,
> >>  
> >>  /* Helper function to update the heartbeat timer. */
> >>  static void sctp_cmd_hb_timer_update(sctp_cmd_seq_t *cmds,
> >> -				     struct sctp_association *asoc,
> >>  				     struct sctp_transport *t)
> >>  {
> >>  	/* Update the heartbeat timer.  */
> >> @@ -1457,7 +1456,7 @@ static int sctp_cmd_interpreter(sctp_event_t event_type,
> >>  
> >>  		case SCTP_CMD_HB_TIMER_UPDATE:
> >>  			t = cmd->obj.transport;
> >> -			sctp_cmd_hb_timer_update(commands, asoc, t);
> >> +			sctp_cmd_hb_timer_update(commands, t);
> >>  			break;
> > 
> > you mean it was not compiling before?
> 
>   I mean this parameter is never used in this function.

Sorry for the disturbance, you're of course right.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html