netdev - Re: [PATCH / RFC 0/2] spinlocks fixup in fec / m68knommu driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47EC9577.2090402@snapgear.com>
Date:	Fri, 28 Mar 2008 16:51:35 +1000
From:	Greg Ungerer <gerg@...pgear.com>
To:	Sebastian Siewior <bigeasy@...utronix.de>
CC:	uclinux-dev@...inux.org, netdev@...r.kernel.org,
	Jeff Garzik <jgarzik@...ox.com>
Subject: Re: [PATCH / RFC 0/2] spinlocks fixup in fec / m68knommu driver

Hi Sebastion,

Sebastian Siewior wrote:
> I got into this after turning on spinlock debugging.
> 
> Jeff: The dev->hard_start_xmit callback is always called from softirq
> context so it is save to use spin_lock_irq(), right?
> 
> Greg: The isr (fec_enet_rx()) calls three functions. All
                 (fec_enet_interrupt())
> but fec_enet_rx() are grabbing the spinlock. Is this on purpose?

No, it looks broken :-(

Regards
Greg



-- 
------------------------------------------------------------------------
Greg Ungerer  --  Chief Software Dude       EMAIL:     gerg@...pgear.com
Secure Computing Corporation                PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html