netdev - Re: [RFC] [NET] [0/2] pskb_expand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47ED97EF.9070601@redhat.com>
Date:	Fri, 28 Mar 2008 21:14:23 -0400
From:	Hideo AOKI <haoki@...hat.com>
To:	David Miller <davem@...emloft.net>
CC:	herbert@...dor.apana.org.au, netdev@...r.kernel.org,
	haoki@...hat.com
Subject: Re: [RFC] [NET] [0/2] pskb_expand_head() bugfix

Hello,

David Miller wrote:
> From: Hideo AOKI <haoki@...hat.com>
> Date: Wed, 26 Mar 2008 16:47:35 -0400
> 
>> I think that it is inconvenient for caller functions to need
>> updateing truesize by themselves.
> 
> Most cases what I can see are in spots where skb->truesize
> cannot be modified because the SKB is possibly charged
> to a socket.
> 
> In these limited situations where skb->truesize adjustments
> really are needed, and legal, it is no harm to open code
> things.

Thank you for the comments.

I understood that updating truesize by caller wasn't problem.
And, I may misunderstand the spots where truesize can't be changed.

Then, I make patch to update truesize for each network subsystem and
ask a review of the patch. 

Best regards,
Hideo

--
Hitachi Computer Products (America) Inc.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html