netdev - Re: [PATCH] 2.6.25-rc6 tulip_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 28 Mar 2008 21:53:25 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Grant Grundler <grundler@...isc-linux.org>
CC:	netdev@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH] 2.6.25-rc6 tulip_read_eeprom fixes for BUG 4420

Grant Grundler wrote:
> Jeff,
> If "location" is > "addr_len" bits, the high bits of location would interfere
> with the READ_CMD sent to the eeprom controller.
> 
> A patch was submitted to bug:
>     http://bugzilla.kernel.org/show_bug.cgi?id=4420
> 
> which simply truncated the "location", read whatever was in "location
> modulo addr_len", and returned that value. That avoids confusing the
> eeprom but seems like the wrong solution to me.
> 
> Correct would be to not read beyond "1 << addr_len" address of the eeprom.
> I am submitting two changes to implement this:
> 1) tulip_read_eeprom will return zero (since we can't return -EINVAL)
>    if this is attempted (defensive programming).
> 2) In tulip_core.c, fix the tulip_read_eeprom caller so they don't
>    iterate past addr_len bits and make sure the entire tp->eeprom[]
>    array is cleared.
> 
> I konw we don't strictly need both. I would prefer both in the tree
> since it documents the issue and provides a second "defense" from
> the bug from creeping back in.
> 
> thanks,
> grant
> 
> Signed-off-by: Grant Grundler <grundler@...isc-linux.org>

applied, after manually removing "Jeff," and "thanks, grant" lines from 
the changelog ;-)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html