netdev - Re: [PATCH 6/8] e1000e: convert ndev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47EDA38F.6080301@garzik.org>
Date:	Fri, 28 Mar 2008 22:03:59 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Auke Kok <auke-jan.h.kok@...el.com>
CC:	netdev@...r.kernel.org, e1000-devel@...ts.sourceforge.net
Subject: Re: [PATCH 6/8] e1000e: convert ndev_ printks to something smaller

Auke Kok wrote:
> From: Bruce Allan <bruce.w.allan@...el.com>
> 
> The ndev_* printk's are too lenghty and we don't need to specify
> the adapter/netdev struct at all, making this a lot more readable.
> 
> Signed-off-by: Bruce Allan <bruce.w.allan@...el.com>
> Signed-off-by: Auke Kok <auke-jan.h.kok@...el.com>
> ---
> 
>  drivers/net/e1000e/e1000.h   |   27 ++++----
>  drivers/net/e1000e/ethtool.c |   38 +++++------
>  drivers/net/e1000e/netdev.c  |  148 +++++++++++++++++++-----------------------
>  drivers/net/e1000e/param.c   |   31 +++------
>  4 files changed, 108 insertions(+), 136 deletions(-)

This stuff should just be removed.

Either the code should be outputting "ethX: blahblah" via printk(), or 
the code should be outputting the standard dev_printk() prefix [driver 
name, PCI device info].

Also, it is recommended to use the NETIF_MSG_xxx bits to permit 
fine-grained control over which messages are output, on a per-port basis 
(controlled via ethtool).  grep around for 'msg_enable'

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html