netdev - [PATCH] sge.c: stop inlining largish static functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <200803310015.35283.vda.linux@googlemail.com>
Date:	Mon, 31 Mar 2008 00:15:35 +0200
From:	Denys Vlasenko <vda.linux@...glemail.com>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] sge.c: stop inlining largish static functions

Hi Jeff,

Can you take this patch into your net driver fixes tree?

I noticed that drivers/net/cxgb3/sge.c has lots of inlined
static functions.

Some of big inlines are single use, but at least make_sgl()
has two callsites. I didn't check every function after it...

This patch removes "inline" from biggest static function
(regardless of number of callsites - gcc nowadays auto-inlines
statics with one callsite).

Size difference for 32bit x86:

   text    data     bss     dec     hex filename
  14036       0       0   14036    36d4 linux-2.6-ALLYES/drivers/net/cxgb3/sge.o
  13185       0       0   13185    3381 linux-2.6.inline-ALLYES/drivers/net/cxgb3/sge.o

Signed-off-by: Denys Vlasenko <vda.linux@...glemail.com>
--
vda

View attachment "sge_deinline.diff" of type "text/x-diff" (12211 bytes)