netdev - Re: [PATCH] [Syncookies:] Add support for TCP-options via timestamps.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080331210033.GA27117@Chamillionaire.breakpoint.cc>
Date:	Mon, 31 Mar 2008 23:00:33 +0200
From:	Florian Westphal <fw@...len.de>
To:	netdev@...r.kernel.org
Subject: Re: [PATCH] [Syncookies:] Add support for TCP-options via
	timestamps.

Glenn Griffin <ggriffin.kernel@...il.com> wrote:
> > +	u32 ts, ts_now = tcp_time_stamp;
> > +
> > +	if (unlikely(options > ts_now)) { /* recent overflow */
> > +		options |= ~(TSMASK);
> > +		return options;
> > +	}
> > +	ts = ts_now & ~TSMASK;
> > +	ts |= options;
> > +	if (ts > ts_now) { /* try to fix up ... */
> > +		ts >>= TSBITS;
> > +		ts--;
> > +		ts <<= TSBITS;
> > +		ts |= options;
> > +	}
> > +        return ts;
> > +}
> 
> I may be missing something obvious, but I'm failing to see where the
> initial if(options > ts_now) does anything different from the more
> generic logic below it.

You're right, I'll drop the first one.

> Also the 'return ts' line is indented using spaces rather than tabs.

Yes. I'll fix this, thanks.

I think it might be better to avoid duplicating 'cookie_check_timestamp()'
in ipv6/syncookies.c; so i'll change that as well.

I'll wait a few hours before submitting an updated version in case
others wish to provide feedback.

Glenn, should I add your SoB-Line when I send an updated version?
After all, this patch re-uses some of your earlier work.

Thanks again for reviewing this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html