netdev - Re: [PATCH 2/2] bluetooth : __rfcomm_dlc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080402.000017.222512990.davem@davemloft.net>
Date:	Wed, 02 Apr 2008 00:00:17 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	hidave.darkstar@...il.com
Cc:	davej@...emonkey.org.uk, netdev@...r.kernel.org,
	linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
	marcel@...tmann.org
Subject: Re: [PATCH 2/2] bluetooth : __rfcomm_dlc_close lock fix

From: Dave Young <hidave.darkstar@...il.com>
Date: Wed, 2 Apr 2008 14:02:43 +0800

> Lockdep warning will be trigged while rfcomm connection closing.
> 
> The locks taken in rfcomm_dev_add:
> rfcomm_dev_lock --> d->lock
> 
> In __rfcomm_dlc_close:
> d->lock --> rfcomm_dev_lock (in rfcomm_dev_state_change)
> 
> There's two way to fix it, one is in rfcomm_dev_add we first locking
> d->lock then the rfcomm_dev_lock
> 
> The other (in this patch), remove the locking of d->lock for
> rfcomm_dev_state_change because just locking "d->state = BT_CLOSED;"
> is enough.

Also applied, thanks a lot Dave!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html