netdev - Re: [PATCH / RFC 0/2] spinlocks fixup in fec / m68knommu driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080402111112.GA11054@Chamillionaire.breakpoint.cc>
Date:	Wed, 2 Apr 2008 13:11:12 +0200
From:	Sebastian Siewior <netdev@...breakpoint.cc>
To:	Jeff Garzik <jgarzik@...ox.com>
Cc:	Sebastian Siewior <bigeasy@...utronix.de>, uclinux-dev@...inux.org,
	netdev@...r.kernel.org, Greg Ungerer <gerg@...inux.org>
Subject: Re: [PATCH / RFC 0/2] spinlocks fixup in fec / m68knommu driver

* Jeff Garzik | 2008-03-28 22:21:05 [-0400]:

> Sebastian Siewior wrote:
>> I got into this after turning on spinlock debugging.
>> Jeff: The dev->hard_start_xmit callback is always called from softirq
>> context so it is save to use spin_lock_irq(), right?
>> Greg: The isr (fec_enet_rx()) calls three functions. All
>> but fec_enet_rx() are grabbing the spinlock. Is this on purpose?

Jeff please drop that one, I form a new patch just located another BUG.
That one triggers on high load on a non-smp, non-preempt machine.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html