netdev - Re: [PATCH net-2.6.26] netlink: make socket filters work on netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1207139106.4451.155.camel@localhost>
Date:	Wed, 02 Apr 2008 08:25:06 -0400
From:	jamal <hadi@...erus.ca>
To:	Patrick McHardy <kaber@...sh.net>
Cc:	Thomas Graf <tgraf@...g.ch>, David Miller <davem@...emloft.net>,
	shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-2.6.26] netlink: make socket filters work on netlink

On Wed, 2008-02-04 at 14:09 +0200, Patrick McHardy wrote:

> Yes, but it was the use of current->pid that was wrong.

There are many many apps out there which still use ioctls - hence the
ambiguity of "is it the kernel that generated the command that caused
the event or was it merely a proxy for some app". 
You need to resolve that. 

> If one of those calls are in a path invoked through netlink
> it should set nlmsg_pid.

Nod - I think thats mostly taken care of; havent looked lately. I know
Alexey didnt object to any patches i submitted that did change how
nlmsg_pid was set on events to match this thought and I cant think of a
reason it would violate any netlink ettiquette. 

Note, I find the whoddunit field (not the pid) to be also useful for
aesthetics and debugging other than for the non-ambiguity in the
filtering.

cheers,
jamal

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html