netdev - Re: [PATCH 1/5] fec: kill warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080403074452.GB778@Chamillionaire.breakpoint.cc>
Date:	Thu, 3 Apr 2008 09:44:52 +0200
From:	Sebastian Siewior <bigeasy@...utronix.de>
To:	Greg Ungerer <gerg@...pgear.com>
Cc:	Jeff Garzik <jgarzik@...ox.com>, netdev@...r.kernel.org,
	uclinux-dev@...inux.org
Subject: Re: [PATCH 1/5] fec: kill warnings

* Greg Ungerer | 2008-04-03 16:30:48 [+1000]:

> Hi Sebastian,
>
> Sebastian Siewior wrote:
>> linux-2.6-mk68/drivers/net/fec.c: In function 'fec_enet_module_init':
>> linux-2.6-mk68/drivers/net/fec.c:2627: warning: unused variable 'j'
>> linux-2.6-mk68/drivers/net/fec.c: At top level:
>> linux-2.6-mk68/drivers/net/fec.c:2136: warning: 'mii_link_interrupt' 
>> defined but not used
>> Signed-off-by: Sebastian Siewior <bigeasy@...utronix.de>
>> --- a/drivers/net/fec.c
>> +++ b/drivers/net/fec.c
>> @@ -67,6 +67,11 @@
>>  #define	FEC_MAX_PORTS	1
>>  #endif
>>  +#if defined(CONFIG_M523x) || defined(CONFIG_M527x) || 
>> defined(CONFIG_M528x) || \
>> +	defined(CONFIG_M520x) || defined(CONFIG_M532x)
>> +#define DONT_NEED_mii_link_interrupt
>
> I think using normal positive logic would be clearer, eg:
>
>   HAVE_mii_link_interupt
Will do it.

> Very few of the boards I have come across with the FEC silicon
> actually hook up the MII interrupt, so the list of devices that
> have it will be smaller.
This doesn't mean we get rid of it, does it? :)

>
> Regards
> Greg
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html