netdev - Re: [PATCH] net: add destructor for skb data.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080406092018.GA32293@2ka.mipt.ru>
Date:	Sun, 6 Apr 2008 13:20:18 +0400
From:	Evgeniy Polyakov <johnpol@....mipt.ru>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] net: add destructor for skb data.

Hi Rusty.

On Sun, Apr 06, 2008 at 01:20:59PM +1000, Rusty Russell (rusty@...tcorp.com.au) wrote:
>     I don't think so.  For a start, the skb destructor is called while the skb 
> is still in the socket queue (ie. the data is still live).  Secondly, the 
> original skb can be freed while clones still reference the data.

That is what it is for - to remove data from any queues and free it.
One can check if skb was cloned and do not perform some steps, instead
call old destructor. Destructor for the last clone will cleanup whatever
is needed. Thoughts?

Actually I'm not that opposed agains additional destructor, I just want
to bring attention to this topic, since this is second time some steps
are going to be setup for the destruction time, so I want a clear
solution :)

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html