netdev - Re: [PATCH net-2.6.26 2/2] Do not allocate unneeded memory for dev->priv alignment.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47FB2FF3.90104@openvz.org>
Date:	Tue, 08 Apr 2008 12:42:27 +0400
From:	Pavel Emelyanov <xemul@...nvz.org>
To:	Jarek Poplawski <jarkao2@...il.com>
CC:	Linux Netdev List <netdev@...r.kernel.org>,
	Stephen Hemminger <shemminger@...tta.com>,
	Patrick McHardy <kaber@...sh.net>
Subject: Re: [PATCH net-2.6.26 2/2] Do not allocate unneeded memory for dev->priv
   alignment.

Jarek Poplawski wrote:
> Pavel Emelyanov wrote, On 04/07/2008 06:31 PM:
> ...
> 
>> ---
>>  net/core/dev.c |    3 ++-
>>  1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/net/core/dev.c b/net/core/dev.c
>> index 7aa0112..80e103a 100644
>> --- a/net/core/dev.c
>> +++ b/net/core/dev.c
>> @@ -4000,7 +4000,8 @@ struct net_device *alloc_netdev_mq(int sizeof_priv, const char *name,
>>  	alloc_size = (sizeof(*dev) + NETDEV_ALIGN_CONST +
>>  		     (sizeof(struct net_device_subqueue) * (queue_count - 1))) &
>>  		     ~NETDEV_ALIGN_CONST;
>> -	alloc_size += sizeof_priv + NETDEV_ALIGN_CONST;
>> +	if (sizeof_priv)
>> +		alloc_size += sizeof_priv + NETDEV_ALIGN_CONST;
>>  
>>  	p = kzalloc(alloc_size, GFP_KERNEL);
>>  	if (!p) {
> 
> 
> IMHO this second "+ NETDEV_ALIGN_CONST" is needed here because of "~NETDEV_ALIGN_CONST".

Hmm, AFAIC, the net_device alignment is done earlier, while this one
makes sense in case the priv pointer alignment.

> Regards,
> Jarek P.
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html