netdev - Re: [PATCH] Stochastic Fair Blue queue discipline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47FB60EF.1080004@trash.net>
Date:	Tue, 08 Apr 2008 14:11:27 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Andi Kleen <andi@...stfloor.org>
CC:	Juliusz Chroboczek <jch@....jussieu.fr>, netdev@...r.kernel.org
Subject: Re: [PATCH] Stochastic Fair Blue queue discipline

Andi Kleen wrote:
> Juliusz Chroboczek <jch@....jussieu.fr> writes:
> 
> 
> Have not read everything. General comment you'll likely need to 
> do some code style cleanups (read Documentation/CodingStyle) 
> Especially indentation should be consistent (one easy way 
> to get that would be to run it through Lindent, although you
> might need to review it afterwards because Lindent sometimes does
> weird things)
> 
>> +
>> +static unsigned sfb_hash(struct sk_buff *skb, int hash, int filter,
>> +                         struct sfb_sched_data *q)
>> +{
>> +	u32 h, h2;
>> +        u8 hash_type = q->hash_type;
>> +
>> +	switch (skb->protocol) {
>> +	case __constant_htons(ETH_P_IP):
> 
> I think we have multiple qdiscs now doing very similar such hashes.
> Any chance this could be factored out into a common library function 
> first?

I'd suggest to use the flow classifier for this. For simplicity
you could attach a default classifier that uses the same keys as
this one.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html