netdev - Re: [ANN] WiMAX stack and drivers for Intel WiMAX Link 5050

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <871w5fpnhs.fsf@basil.nowhere.org>
Date:	Wed, 09 Apr 2008 08:10:23 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Inaky Perez-Gonzalez 
	<public-inaky-VuQAYsv1563Yd54FQh9/CA@...h.gmane.org>
Cc:	Stephen Hemminger 
	<public-stephen.hemminger-ZtmgI6mnKB3QT0dZR+AlfA@...h.gmane.org>,
	public-wimax-BPSAo7wm5JOHVYUYWc+uSQ@...h.gmane.org,
	public-linux-wireless-u79uwXL29TY76Z2rM5mHXA@...h.gmane.org,
	public-netdev-u79uwXL29TY76Z2rM5mHXA@...h.gmane.org,
	public-linux-kernel-u79uwXL29TY76Z2rM5mHXA@...h.gmane.org
Subject: Re: [ANN] WiMAX stack and drivers for Intel WiMAX Link 5050



Inaky Perez-Gonzalez <inaky-VuQAYsv1563Yd54FQh9/CA@...lic.gmane.org> writes:
>
> There is almost no inlining because each X only does stuff from itself. If
> there is a need for inlined stuff (I missed it) it should go to one of the
> header files --internal or external.

Inlining gets more and more discouraged. Also longer term I would 
expect that gcc will do inlining over files anyways (it already supports
that, but needs special support in the Makefiles which the kernel
doesn't have). So even with inlining you wouldn't need to merge files
or move code into headers.

> version: I anticipate the wimax API exported to user space is
> going to undergo a lot of changes while we all agree on what
> is the best interface. Because things might break, I want to
> make sure user space stuff can detect that and fail cleanly. 
> Hence the versioning. 

It's still a bad way to do that (I agree with Stephen on that).
Was also always a mess on wireless.

If you don't want expandable TLAs another better alternative to 
versions is ext2 style compatible/incompatible feature bitmaps.

-Andi


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html