netdev - Re: [patch] e1000=y && e1000e=m regression fix (was: Re: [regression] e1000e broke e1000)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m3prsxpf4m.fsf@maximus.localdomain>
Date:	Thu, 10 Apr 2008 23:35:37 +0200
From:	Krzysztof Halasa <khc@...waw.pl>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Frans Pop <elendil@...net.nl>, Ingo Molnar <mingo@...e.hu>,
	jeff@...zik.org, matthew@....cx, auke-jan.h.kok@...el.com,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	e1000-devel@...ts.sourceforge.net,
	linux-pci@...ey.karlin.mff.cuni.cz, akpm@...ux-foundation.org,
	davem@...emloft.net, jesse.brandeburg@...el.com,
	john.ronciak@...el.com, bruce.w.allan@...el.com, greg@...ah.com,
	arjan@...ux.intel.com, rjw@...k.pl
Subject: Re: [patch] e1000=y && e1000e=m regression fix (was: Re: [regression] e1000e broke e1000)

Linus Torvalds <torvalds@...ux-foundation.org> writes:

> No it wouldn't, not when the driver we used forever suddenly stopped 
> supporting them.

In this case e1000 stops supporting them only if you enable e1000e
too. No e1000e, e1000 still does those IDs. For now, if I understand
it correctly. And it seems to print a warning.

So it doesn't work if you make e1000e a module and don't load it.

> And no, I'm not talking about some theoretical "this could happen" thing. 
> I hit exactly that with commit
> 040babf9d84e7010c457e9ce69e9eb1c27927c9e 

Right. Now it's a different situation, though.
-- 
Krzysztof Halasa
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html