netdev - Re: [PATCH 5/6] IPV4: route use jhash3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080410.015448.00224349.davem@davemloft.net>
Date:	Thu, 10 Apr 2008 01:54:48 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 5/6] IPV4: route use jhash3

From: Stephen Hemminger <shemminger@...tta.com>
Date: Mon, 31 Mar 2008 17:47:13 -0700

> Since route hash is a triple, use jhash_3words rather doing the mixing
> directly. This should be as fast and give better distribution.
> 
> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>

Applied to net-2.6.26, but:

> -static unsigned int rt_hash_code(u32 daddr, u32 saddr)
> +static inline unsigned int rt_hash(__be32 daddr, __be32 saddr, int idx)

Are you sure you want to inline that?  jhash expands
to a lot of instructions
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html