netdev - Re: [PATCH] [Syncookies]: Add support for TCP options via timestamps.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080410.031257.07927100.davem@davemloft.net>
Date:	Thu, 10 Apr 2008 03:12:57 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	fw@...len.de
Cc:	netdev@...r.kernel.org, ggriffin.kernel@...il.com
Subject: Re: [PATCH] [Syncookies]: Add support for TCP options via
 timestamps.

From: Florian Westphal <fw@...len.de>
Date: Wed,  2 Apr 2008 03:54:12 +0200

> Allow the use of SACK and window scaling when syncookies are used
> and the client supports tcp timestamps. Options are encoded into
> the timestamp sent in the syn-ack and restored from the timestamp
> echo when the ack is received.
> 
> Based on earlier work by Glenn Griffin.
> This patch avoids increasing the size of structs by encoding TCP
> options into the least significant bits of the timestamp and
> by not using any 'timestamp offset'.
> 
> The downside is that the timestamp sent in the packet after the synack
> will increase by several seconds.
> 
> Reviewed-by: Hagen Paul Pfeifer <hagen@...u.net>
> Signed-off-by: Florian Westphal <fw@...len.de>
> CC: Glenn Griffin <ggriffin.kernel@...il.com>
> ---
>  changes since v1:
>  don't duplicate timestamp echo decoding function, put it into ipv4/syncookie.c
>  and have ipv6/syncookies.c use it.
>  Feedback from Glenn Griffin: fix line indented with spaces, kill redundant if ()

Looks good, patch applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html