netdev - [PATCH] [mcast-tools] Changing the type of pim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <147a89290804110214nb1cc55fp4645ce1f913d74d6@mail.gmail.com>
Date:	Fri, 11 Apr 2008 12:14:37 +0300
From:	"Andy Johnson" <johnsonzjo@...il.com>
To:	"David Miller" <davem@...emloft.net>
Cc:	yoshfuji@...ux-ipv6.org, netdev@...r.kernel.org
Subject: [PATCH] [mcast-tools] Changing the type of pim_cksum.

Hello,

>In glibc-2.3.x both defines were provided, but after that the old
>ICMP6_* defines were completely removed.

>Probably Yoshifuji-san tests the user tool builds on a glibc-2.3.x or
>earlier system, which has the old deprecated defines.

I could get access today (at last...) to a machine running glibc-2.3.4-2.13.
I had done the following:
git-clone git://git.linux-ipv6.org/gitroot/yoshfuji/mcast-tools.git

cd mcast-tools

aclocal; automake; autoconf
./configure
cd pim6sd
make

I got the following error:

In file included from debug.c:71:
../include/linux/pim.h:17: error: syntax error before "__be16"
../include/linux/pim.h:17: warning: no semicolon at end of struct or union
make[1]: *** [debug.o] Error 1
make[1]: Leaving directory ...
make: *** [all-recursive] Error 1

As far as I understand, the __be16 is good for kernel headers, but not
for user space headers. I am not sure about it. However, in case I am
right, I changed it to  "uint16_t pim_cksum" instead of  "__be16  pim_cksum"
in /include/linux/pim.h;
and then "make" finsihed ok.
And attached here is the patch. What do you think ?

Regards,
AJ

Signed-off-by: Andy Johnson <johnsonzjo@...il.com>

On Tue, Apr 8, 2008 at 12:14 PM, David Miller <davem@...emloft.net> wrote:
> From: "Andy Johnson" <johnsonzjo@...il.com>
>  Date: Tue, 8 Apr 2008 09:57:39 +0300
>
>
>  > mld6.c: In function 'init_mld6':
>  > mld6.c:210: error: 'ICMP6_MEMBERSHIP_QUERY' undeclared (first use in
>  > this function)
>  > mld6.c:210: error: (Each undeclared identifier is reported only once
>  > mld6.c:210: error: for each function it appears in.)
>  > mld6.c:211: error: 'ICMP6_MEMBERSHIP_REPORT' undeclared (first use in
>  > this function)
>  > mld6.c:212: error: 'ICMP6_MEMBERSHIP_REDUCTION' undeclared (first use
>  > in this function)
>  > mld6.c: In function 'accept_mld6':
>  > mld6.c:451: error: 'MLD_LISTENER_DONE' undeclared (first use in this function)
>
>  Somewhere along the line ICMP6_MEMBERSHIP_* got changed
>  into MLD_LISTENER_* in the glibc headers.
>
>  Similarly MLD_LISTENER_DONE should be MLD_LISTENER_REDUCTION.
>
>  In glibc-2.3.x both defines were provided, but after that the old
>  ICMP6_* defines were completely removed.
>
>  Probably Yoshifuji-san tests the user tool builds on a glibc-2.3.x or
>  earlier system, which has the old deprecated defines.
>
>  So if you simply change:
>
>         ICMP6_MEMBERSHIP_* --> MLD_LISTENER_*
>
>  and also:
>
>         MLD_LISTENER_DONE --> MLD_LISTENER_REDUCTION
>
>  the build will complete successfully.
>

View attachment "patch.txt" of type "text/plain" (350 bytes)