netdev - Re: [PATCH] macb: Use semicolon instead of comma for statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48005E64.1090401@garzik.org>
Date:	Sat, 12 Apr 2008 03:01:56 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Atsushi Nemoto <anemo@....ocn.ne.jp>
CC:	Haavard Skinnemoen <hskinnemoen@...el.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] macb: Use semicolon instead of comma for statement

Atsushi Nemoto wrote:
> It seems no good reason to use comma here.
> 
> Signed-off-by: Atsushi Nemoto <anemo@....ocn.ne.jp>
> ---
> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
> index 1d210ed..0881690 100644
> --- a/drivers/net/macb.c
> +++ b/drivers/net/macb.c
> @@ -242,12 +242,12 @@ static int macb_mii_init(struct macb *bp)
>  	/* Enable managment port */
>  	macb_writel(bp, NCR, MACB_BIT(MPE));
>  
> -	bp->mii_bus.name = "MACB_mii_bus",
> -	bp->mii_bus.read = &macb_mdio_read,
> -	bp->mii_bus.write = &macb_mdio_write,
> -	bp->mii_bus.reset = &macb_mdio_reset,
> -	bp->mii_bus.id = bp->pdev->id,
> -	bp->mii_bus.priv = bp,
> +	bp->mii_bus.name = "MACB_mii_bus";
> +	bp->mii_bus.read = &macb_mdio_read;
> +	bp->mii_bus.write = &macb_mdio_write;
> +	bp->mii_bus.reset = &macb_mdio_reset;
> +	bp->mii_bus.id = bp->pdev->id;
> +	bp->mii_bus.priv = bp;
>  	bp->mii_bus.dev = &bp->dev->dev;
>  	pdata = bp->pdev->dev.platform_data;
>  

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html