netdev - Re: [patch for 2.6.25? 1/3] forcedeth: mac address fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <480075F8.4050801@garzik.org>
Date:	Sat, 12 Apr 2008 04:42:32 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	akpm@...ux-foundation.org
CC:	netdev@...r.kernel.org, aabdulla@...dia.com, yhlu.kernel@...il.com
Subject: Re: [patch for 2.6.25? 1/3] forcedeth: mac address fix

akpm@...ux-foundation.org wrote:
> From: Ayaz Abdulla <aabdulla@...dia.com>
> 
> This critical patch fixes a mac address issue recently introduced.  If the
> device's mac address was in correct order and the flag
> NVREG_TRANSMITPOLL_MAC_ADDR_REV was set, during nv_remove the flag would get
> cleared.  During next load, the mac address would get reversed because the
> flag is missing.
> 
> As it has been indicated previously, the flag is cleared across a low power
> transition.  Therefore, the driver should set the mac address back into the
> reversed order when clearing the flag.
> 
> Also, the driver should set back the flag after a low power transition to
> protect against kexec command calling nv_probe a second time.
> 
> Signed-off-by: Ayaz Abdulla <aabdulla@...dia.com>
> Cc: "Yinghai Lu" <yhlu.kernel@...il.com>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> ---
> 
>  drivers/net/forcedeth.c |   26 ++++++++++++++++++++++++--
>  1 file changed, 24 insertions(+), 2 deletions(-)

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html