netdev - Re: [PATCH] [ETHTOOL]: Add support for large eeproms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48007CA0.6030002@garzik.org>
Date:	Sat, 12 Apr 2008 05:10:56 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Mandeep Singh Baines <msb@...gle.com>
CC:	Joe Perches <joe@...ches.com>, netdev@...r.kernel.org,
	matthew@....cx, davem@...emloft.net, nil@...gle.com,
	thockin@...gle.com
Subject: Re: [PATCH] [ETHTOOL]: Add support for large eeproms

Mandeep Singh Baines wrote:
> Joe Perches (joe@...ches.com) wrote:
>> This looks better.
>> There's a typo at line 315 though, it needs a ";".
>>
> 
> Oops. In my haste to get out the revised patch I didn't bother to test.
> Bad Mandeep.
> 
>> I was also wrong that int ret _does_ need to be
>> initialized to 0 in case (eeprom.len == 0)
>>
> 
> I knew I had that there for a reason. But I forgot to initialize ret in
> ethtool_get_eeprom. You've fixed this in your update to the patch:)
> 
>> I think this should be written as below:
>>
> 
> Agreed. You've fixed my bugs and I think setting ret inside the if
> makes the code easier to reason about.
> 
> I've tested your updated version of the patch and it looks good.
> 
>> cheers, Joe
>>
>>  net/core/ethtool.c |   68 +++++++++++++++++++++++++++++-----------------------
>>  1 files changed, 38 insertions(+), 30 deletions(-)

someone wanna resend with proper sign-offs?


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html