[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1208033230.5869.18.camel@vader.jdub.homelinux.org>
Date: Sat, 12 Apr 2008 15:47:10 -0500
From: Josh Boyer <jwboyer@...ux.vnet.ibm.com>
To: Jeff Garzik <jeff@...zik.org>
Cc: linuxppc-dev@...abs.org, netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] ibm_newemac: PowerPC 440GX EMAC PHY clock
workaround
On Sat, 2008-04-12 at 16:28 -0400, Jeff Garzik wrote:
> Josh Boyer wrote:
> > On Fri, 28 Mar 2008 22:18:25 -0400
> > Jeff Garzik <jeff@...zik.org> wrote:
> >
> >> Valentine Barshak wrote:
> >>> The PowerPC 440GX Taishan board fails to reset EMAC3 (reset timeout error)
> >>> if there's no link. Because of that it fails to find PHY chip. The older ibm_emac
> >>> driver had a workaround for that: the EMAC_CLK_INTERNAL/EMAC_CLK_EXTERNAL macros,
> >>> which toggle the Ethernet Clock Select bit in the SDR0_MFR register. This patch
> >>> does the same for "ibm,emac-440gx" compatible chips. The workaround forces
> >>> clock on -all- EMACs, so we select clock under global emac_phy_map_lock.
> >>>
> >>> Signed-off-by: Valentine Barshak <vbarshak@...mvista.com>
> >>> ---
> >>> drivers/net/ibm_newemac/core.c | 16 +++++++++++++++-
> >>> drivers/net/ibm_newemac/core.h | 8 ++++++--
> >>> 2 files changed, 21 insertions(+), 3 deletions(-)
> >> is this for 2.6.25-rc?
> >
> > Jeff, can I get an ack from you on this patch, and patch 2 in this
> > set? They depend on a patch in my tree and I'd like to include them in
> > my next push to Paul for 2.6.26.
>
> ACK
Many thanks.
> I had queried the status of these patches, and didn't receive any reply
> initially from my query...
Erm... you did.
http://ozlabs.org/pipermail/linuxppc-dev/2008-March/053737.html
No worries though. I lose email all the time.
josh
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists