netdev - Re: [PATCH] [NET] [ISDN]: Do not validate ISDN net device address prior to interface-up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080413085135.GB2788@ami.dom.local>
Date:	Sun, 13 Apr 2008 10:51:35 +0200
From:	Jarek Poplawski <jarkao2@...il.com>
To:	Patrick McHardy <kaber@...sh.net>
Cc:	Paul Bolle <pebolle@...cali.nl>, netdev@...r.kernel.org,
	isdn4linux@...tserv.isdn4linux.de, Jeff Garzik <jgarzik@...hat.com>
Subject: Re: [PATCH] [NET] [ISDN]: Do not validate ISDN net device address
	prior to interface-up

On Sun, Apr 13, 2008 at 10:26:49AM +0200, Patrick McHardy wrote:
...
> This one is simply a bug, not a functional change.

I agree 100%. But since it worked for some people for long time...

>>  BTW, I've assisted some similar case in
>> bugzilla, and I guess users will still ask for an explanation after
>> this error code change.
>>   
>
> Well, I don't have particulary strong feelings about this, but
> I think adding a printk to one out of thousands of possible
> errors won't help much.

Maybe you are right, we can simply wait. I know Paul, me and a few
more people lost "a bit" of time because of this fix already, and
I hope the next time there will be somebody like you around to give
an advice before git bisect was finished or a few kB of logs are sent
here.

Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html