netdev - Re: [PATCH]: net/bonding: Enable to change device type before enslaving

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48021410.5040806@voltaire.com>
Date:	Sun, 13 Apr 2008 17:09:20 +0300
From:	Moni Shoua <monis@...taire.com>
To:	Jay Vosburgh <fubar@...ibm.com>
CC:	netdev <netdev@...r.kernel.org>, Olga Stern <olgas@...taire.com>,
	Or Gerlitz <ogerlitz@...taire.com>
Subject: Re: [PATCH]: net/bonding: Enable to change device type before enslaving

> 	Does this mean that the automatic selection on first enslavement
> is no longer needed, and all setting of the type for IB devices must
> occur prior to first enslavement?
> 
> 	Or is this more of a special case for some devices, and the
> automatic selection is still correct for most cases?
> 

I think that the later is closer to the truth. 
The goal is to modify the bonding module to work with IPoIB slaves but
with as small as possible changes to what already exists.

In details, the bonding net device device gets its type by ether_setup(),
which runs for all types of slaves and I don't see a way to change that.
However, bonding master for IPoIB slaves requires a different device type setting 
before it comes up for some OSs (redhat 4 for instance). On other OSs I don't see the problem 
and I guess that this is because master becomes up only after it has slaves.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html