netdev - UFO csum - udp4_hwcsum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <BAY121-W330A647FE33FFA81C4F7DFB6E90@phx.gbl>
Date:	Sun, 13 Apr 2008 14:41:39 +0000
From:	Kostya B <bkostya@...mail.com>
To:	<netdev@...r.kernel.org>
Subject: UFO csum - udp4_hwcsum_outgoing

Hi,
Suppose a network driver with both TSO and UFO support (2.6.22.18). 
Normally on Tx, all outgoing skb are checksummed as PARTIAL. However, the udp4_hwcsum_outgoing() could change it to be CHECKSUM_NONE.

In that case such skb  becomes netif_needs_gso() and wrongly ask for software gso:

	return skb_is_gso(skb) &&
	       (!skb_gso_ok(skb, dev->features) ||
		unlikely(skb->ip_summed != CHECKSUM_PARTIAL));

Is that intentional? It looks quite weird, because UFO drivers declare NETIF_F_HW_CSUM.
Furthermore it treated by __software__  skb_gso_segment() and fails on 

BUG_ON(skb_shinfo(skb)->frag_list); 

Please advice.

- Kostya

_________________________________________________________________
Explore the seven wonders of the world
http://search.msn.com/results.aspx?q=7+wonders+world&mkt=en-US&form=QBRE
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html