netdev - Re: [PATCH take2][NET_SCHED] cls_u32: refcounting fix for u32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080412.183723.161646190.davem@davemloft.net>
Date:	Sat, 12 Apr 2008 18:37:23 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	hadi@...erus.ca
Cc:	jarkao2@...il.com, kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: [PATCH take2][NET_SCHED] cls_u32: refcounting fix for
 u32_delete()

From: jamal <hadi@...erus.ca>
Date: Fri, 11 Apr 2008 09:55:27 -0400

> On Fri, 2008-11-04 at 13:48 +0000, Jarek Poplawski wrote:
> > On Fri, Apr 11, 2008 at 03:22:51PM +0200, Patrick McHardy wrote:
> > ...
> > > I'd suggest to behave similar to qdiscs when trying to
> > > removing classes that are still referenced, return -EBUSY.
> > 
> > Of course you are right!
> > 
> > Jarek P.
> > 
> > -------------------> (take 2)
> > 
> > [NET_SCHED] cls_u32: refcounting fix for u32_delete()
> > 
> > Deleting of nonroot hnodes mostly doesn't work in u32_delete():
> > refcnt == 1 is expected, but such hnodes' refcnts are initialized
> > with 0 and charged only with "link" nodes. Now they'll start with
> > 1 like usual. Thanks to Patrick McHardy for an improving suggestion.
> > 
> > 
> > Signed-off-by: Jarek Poplawski <jarkao2@...il.com>
> > Cc: Jamal Hadi Salim <hadi@...erus.ca>
> 
> Thanks as always Jarek.
> 
> Acked-by: Jamal Hadi Salim <hadi@...erus.ca>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html