netdev - Re: [PATCH v2.6.26] gianfar: Determine TBIPA value dynamically

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 14 Apr 2008 11:55:11 -0500
From:	Andy Fleming <afleming@...escale.com>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	netdev@...r.kernel.org, linuxppc-dev@...abs.org
Subject: Re: [PATCH v2.6.26] gianfar: Determine TBIPA value dynamically


On Apr 11, 2008, at 10:49, Paul Gortmaker wrote:

> In message: [PATCH v2.6.26] gianfar: Determine TBIPA value dynamically
> on 10/04/2008 Andy Fleming wrote:
>
>> TBIPA needs to be set to a value (on connected MDIO buses) that  
>> doesn't
>> conflict with PHYs on the bus.  By hardcoding it to 0x1f, we were  
>> preventing
>> boards with PHYs at 0x1f from working properly.  Instead, scan the  
>> bus when
>> it comes up, and find an address that doesn't have a PHY on it.   
>> The TBI PHY
>> configuration code then trusts that the value in TBIPA is either  
>> safe, or
>> doesn't matter (ie - it's not an active bus with other PHYs).
>>
>> Signed-off-by: Andy Fleming <afleming@...escale.com>
>> ---
>>
>> I think this should go in, but I'd like to see some testing first.   
>> I don't
>> have hardware which is affected by this.  I've only confirmed that  
>> it doesn't
>> break current hardware.
>
> I've tested on a board with the primary PHY at 0x1f, and it seems OK.
>
> I'f I'm understanding this correctly, you are explicitly setting TBIPA
> to zero, doing a bus walk but excluding zero, and then assigning the
> found free address, which re-opens zero to be used by a real PHY.


Right.  It's a somewhat lazy scan of the bus.  I'm assuming, here,  
that there will be at least one non-zero address that has no PHY on it.


>
>
> I've made some changes to what you'd sent out, those being:
> 	-changed the "if (i < 0) return -EBUSY to "i == 0"
> 	-remove the now unused TBIPA_VALUE define
> 	-remove the prototypes from gianfar.c now that you've
> 	 added them into gianfar.h
> 	-factor out the code to read the PHY ID so we don't have
> 	 it duplicated in two places.


Excellent.  Print it!  :)

Could you send out the two patches as two separate emails, and add my  
Acked-by: Andy Fleming <afleming@...escale.com> to the first one?  You  
should also change the subject for the first patch so that it has  
[PATCH v2.6.26].

Andy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html