netdev - Re: 2.6.25-rc9: Reported regressions from 2.6.24

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080414203111.GB26591@gospo.usersys.redhat.com>
Date:	Mon, 14 Apr 2008 16:31:11 -0400
From:	Andy Gospodarek <andy@...yhouse.net>
To:	Patrick McHardy <kaber@...sh.net>
Cc:	Pavel Emelyanov <xemul@...nvz.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Natalie Protasevich <protasnb@...il.com>,
	Linux Netdev List <netdev@...r.kernel.org>,
	andy@...yhouse.net
Subject: Re: 2.6.25-rc9: Reported regressions from 2.6.24

On Sun, Apr 13, 2008 at 10:18:54PM +0200, Patrick McHardy wrote:
> Patrick McHardy wrote:
> >>>
> >>>Bug-Entry    : http://bugzilla.kernel.org/show_bug.cgi?id=10323
> >>>Subject        : panic using bridging on linus kernel 2.6.25-rc6
> >>>Submitter    : Andy Gospodarek <andy@...yhouse.net>
> >>>Date        : 2008-03-25 11:40 (20 days old)
> >>
> >>This looks like another network-namespace regression.
> >>icmp_send() does:
> >>
> >>       net = rt->u.dst.dev->nd_net;
> >>
> >>The bridge netfilter code attaches a fake dst_entry to the
> >>skb which has dev == NULL when passing it to IPv4 netfilter.
> >>
> >>Pavel, do you have a better ideas for fixing this than
> >>instantiating a dst_entry in br_netfilter.c for every
> >>device (or at least for every namespace)? 
> >
> >The description of the problem was not entirely correct, the
> >bridge-netfilter dst_entry does have a proper device pointer,
> >it points to a dummy net_device structure however that doesn't
> >have a namespace associated with it. This blows up in
> >__ip_route_output_key.
> 
> For now I suggest this fix. Andy, could you please test whether it
> fixes the problem?
> 
> 

I'm guessing it will.  I've been testing my older kernels today and
somehow I'm unable to reproduce the original problem, so I need to
figure out what is different about my config now and before.

I'll definitely post back when I test this, but I wanted to make sure
you guys knew I was at least trying it. :)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html