netdev - Re: [RFC] Patch to option HSO driver to the kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200804142342.08116.ajb@spheresystems.co.uk>
Date:	Mon, 14 Apr 2008 23:42:07 +0100
From:	"Andrew Bird (Sphere Systems)" <ajb@...eresystems.co.uk>
To:	Matthew Dharm <mdharm-usb@...-eyed-alien.net>
Cc:	Greg KH <greg@...ah.com>, linux-usb@...r.kernel.org,
	netdev@...r.kernel.org, Alan Cox <alan@...rguk.ukuu.org.uk>,
	Filip Aben <f.aben@...ion.com>,
	Paulius Zaleckas <paulius.zaleckas@...tonika.lt>
Subject: Re: [RFC] Patch to option HSO driver to the kernel

Hi Matthew,
	I'd prefer the keep it as just 'hso' and change the textual description if 
necessary. I think module names are just arbitrary, and should not 
necessarily reflect the original usage too well, otherwise you end up with a 
situation like with the 'option' module. That module is now used for many 
devices from differing manufacturers and it doesn't really make much sense to 
load the option module to service a device from Novatel, Sierra Wireless or 
Huawei.

Just my two pence,


Andrew


On Monday 14 April 2008 22:59, Matthew Dharm wrote:
> I will be the first to admit that I'm picking a nit here, but...
>
> On Mon, Apr 14, 2008 at 02:32:39PM -0700, Greg KH wrote:
> > Subject: USB: add option hso driver
> >
> > +config USB_HSO
> > +	tristate "Option USB High Speed Mobile Devices"
> >
> > + * Driver for Option High Speed Mobile Devices.
> >
> > +#define MOD_DESCRIPTION			"USB High Speed Option driver"
>
> Would it be possible to pick one of "High Speed Option" and "Option...
> High Speed" and then be consistent with the acronym of "hso" or "ohs"?  Or
> maybe call it "option_hs" or something even more clear?
>
> Mixing them just makes it more difficult for people to use grep and google.
>
> Matt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html