netdev - Re: [PATCH] [NET] [ISDN]: Do not validate ISDN net device address prior to interface-up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080414060720.GB4016@ff.dom.local>
Date:	Mon, 14 Apr 2008 06:07:20 +0000
From:	Jarek Poplawski <jarkao2@...il.com>
To:	Patrick McHardy <kaber@...sh.net>
Cc:	David Miller <davem@...emloft.net>, pebolle@...cali.nl,
	netdev@...r.kernel.org, isdn4linux@...tserv.isdn4linux.de,
	jgarzik@...hat.com
Subject: Re: [PATCH] [NET] [ISDN]: Do not validate ISDN net device address
	prior to interface-up

On Mon, Apr 14, 2008 at 07:57:31AM +0200, Patrick McHardy wrote:
> Jarek Poplawski wrote:
...
>> Maybe I missed Patrick point, but it seems this patch isn't good:
>> it omits address validation hiding possible problems.
> The ISDN device's address is computed from the IP addresses
> in ->open(), so there is nothing to validate at the time
> eth_validate_addr() is called.

...So I missed the point, sorry!

Thanks for the explanation,
Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html