netdev - Re: [Bugme-new] [Bug 10437] New: MSG_ERRQUEUE messages do not pass to connected raw sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080413.231544.83437216.davem@davemloft.net>
Date:	Sun, 13 Apr 2008 23:15:44 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	akpm@...ux-foundation.org
Cc:	dmitry@...skoy.name, bugme-daemon@...zilla.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [Bugme-new] [Bug 10437] New: MSG_ERRQUEUE messages do not pass
 to connected raw sockets

From: Andrew Morton <akpm@...ux-foundation.org>
Date: Thu, 10 Apr 2008 10:34:44 -0700

> Dmitry, I'd suggest that you send the patch via email to
> netdev@...r.kernel.org and to YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>.

This person is having trouble emailing things to the lists and elsewhere,
for whatever reason, and he states this in the bugzilla entry so asking
him to email a patch somewhere isn't going to help.

The code in this area has changed a bit, here is the patch I just checked
into net-2.6 and which I'll push to Linus for 2.6.25 and will also submit
for the 2.6.24-stable branch.

commit b45e9189c058bfa495073951ff461ee0eea968be
Author: David S. Miller <davem@...emloft.net>
Date:   Sun Apr 13 23:14:15 2008 -0700

    [IPV6]: Fix ipv6 address fetching in raw6_icmp_error().
    
    Fixes kernel bugzilla 10437
    
    Based almost entirely upon a patch by Dmitry Butskoy.
    
    When deciding what raw sockets to deliver the ICMPv6
    to, we should use the addresses in the ICMPv6 quoted
    IPV6 header, not the top-level one.
    
    Signed-off-by: David S. Miller <davem@...emloft.net>

diff --git a/net/ipv6/raw.c b/net/ipv6/raw.c
index 8897ccf..0a6fbc1 100644
--- a/net/ipv6/raw.c
+++ b/net/ipv6/raw.c
@@ -372,8 +372,10 @@ void raw6_icmp_error(struct sk_buff *skb, int nexthdr,
 	read_lock(&raw_v6_hashinfo.lock);
 	sk = sk_head(&raw_v6_hashinfo.ht[hash]);
 	if (sk != NULL) {
-		saddr = &ipv6_hdr(skb)->saddr;
-		daddr = &ipv6_hdr(skb)->daddr;
+		struct ipv6hdr *hdr = (struct ipv6hdr *) skb->data;
+
+		saddr = &hdr->saddr;
+		daddr = &hdr->daddr;
 		net = skb->dev->nd_net;
 
 		while ((sk = __raw_v6_lookup(net, sk, nexthdr, saddr, daddr,
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html