netdev - Re: [RFC][PATCH 1/3] Introduce the net_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080413.212021.226316980.davem@davemloft.net>
Date:	Sun, 13 Apr 2008 21:20:21 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	kaber@...sh.net
Cc:	shemminger@...tta.com, xemul@...nvz.org, netdev@...r.kernel.org
Subject: Re: [RFC][PATCH 1/3] Introduce the net_device_ops structure.

From: Patrick McHardy <kaber@...sh.net>
Date: Fri, 04 Apr 2008 17:54:55 +0200

> Stephen Hemminger wrote:
> > On Fri, 04 Apr 2008 18:10:52 +0400
> > Pavel Emelyanov <xemul@...nvz.org> wrote:
> > 
> >> And fill it with copied from net_device.
> >>
> >> Also make newly created devices be assigned to the 
> >> (currently empty) nd_default_ops.
> >>
> >> Signed-off-by: Pavel Emelyanov <xemul@...nvz.org>
> > 
> > Thanks, I started this a while back but never got to the bottom.
> > Please use const where possible (on dev->nd_ops) and in devices.
> 
> 
> It might make sense to keep hard_start_xmit and hard_header
> in struct net_device since VLAN and Bonding overload them.

I echo the sentiments of Stephen (use const as much as possible)
and Patrick here.

In particular what Patrick is mentioning deserves special emphasis.

There are so many weird cases that take an existing device and then
overload one of the method pointers arbitrarily.  And I know this is
not at all limited to hard_start_xmit and hard_header.

It may therefore be very difficult to get things all the way over to
nd_ops except for a very small number pointers.  And unfortunately, if
this cannot be overcome, it limits the usefullness of the change. :-/

I encourage this work, nonetheless.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html