netdev - Re: [PATCH] [net-2.6.26] [IPV6] Add stats in multicast routing module method ip6_mr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080414.155916.22280629.yoshfuji@linux-ipv6.org>
Date:	Mon, 14 Apr 2008 15:59:16 +0900 (JST)
From:	YOSHIFUJI Hideaki / 吉藤英明 
	<yoshfuji@...ux-ipv6.org>
To:	davem@...emloft.net
Cc:	ramirose@...il.com, netdev@...r.kernel.org, yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH] [net-2.6.26] [IPV6] Add stats in multicast routing
 module method ip6_mr_forward().

In article <20080413.231806.221764599.davem@...emloft.net> (at Sun, 13 Apr 2008 23:18:06 -0700 (PDT)), David Miller <davem@...emloft.net> says:

> From: "Rami Rosen" <ramirose@...il.com>
> Date: Thu, 10 Apr 2008 21:21:12 +0300
> 
> >   This patches adds a call to increment IPSTATS_MIB_OUTFORWDATAGRAMS
> >    when forwarding the packet in ip6_mr_forward() in the IPv6
> > multicast routing module (net/ipv6/ip6mr.c).
> > 	
> > Signed-off-by: Rami Rosen <ramirose@...il.com>
> 
> This looks OK to me, but I'll let Yoshifuji pick it up.

I'm okay with it.
Here it is.

----
>From e70bc6976e796815e176912a92f72719f7276de1 Mon Sep 17 00:00:00 2001
From: Rami Rosen <ramirose@...il.com>
Date: Thu, 10 Apr 2008 21:21:12 +0300
Subject: [PATCH] [IPV6] MROUTE: Add stats in multicast routing module method ip6_mr_forward().

This patches adds a call to increment IPSTATS_MIB_OUTFORWDATAGRAMS
when forwarding the packet in ip6_mr_forward() in the IPv6
multicast routing module (net/ipv6/ip6mr.c).

Signed-off-by: Rami Rosen <ramirose@...il.com>
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
---
 net/ipv6/ip6mr.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/ipv6/ip6mr.c b/net/ipv6/ip6mr.c
index 94ede69..0971f4b 100644
--- a/net/ipv6/ip6mr.c
+++ b/net/ipv6/ip6mr.c
@@ -1359,7 +1359,7 @@ int ip6mr_ioctl(struct sock *sk, int cmd, void __user *arg)
 
 static inline int ip6mr_forward2_finish(struct sk_buff *skb)
 {
-	/* XXX stats */
+	IP6_INC_STATS_BH(ip6_dst_idev(skb->dst), IPSTATS_MIB_OUTFORWDATAGRAMS);
 	return dst_output(skb);
 }
 
-- 
1.4.4.4

-- 
YOSHIFUJI Hideaki @ USAGI Project  <yoshfuji@...ux-ipv6.org>
GPG-FP  : 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html