netdev - Re: [PATCH] Discard tcp out-of-order queue if system limit is reached

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080415082259.7a911aaf@extreme>
Date:	Tue, 15 Apr 2008 08:22:59 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Vitaliy Gusev <vgusev@...nvz.org>
Cc:	David Miller <davem@...emloft.net>,
	Andi Kleen <andi@...stfloor.org>,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>, netdev@...r.kernel.org
Subject: Re: [PATCH] Discard tcp out-of-order queue if system limit is
 reached

On Tue, 15 Apr 2008 18:54:44 +0400
Vitaliy Gusev <vgusev@...nvz.org> wrote:

> Hello!
> 
> tcp_prune_queue() doesn't prune an out-of-order queue if socket
> is under rcvbuf. However even if socket is under rcvbuf but system-wide limit is
> reached then skb cannot be queued. It can lead to deadlock situation as any skb that
> fills sequence hole is dropped.
> So discard out-of-order queue if system-wide limit is reached.
> 
> Signed-off-by: Vitaliy Gusev <vgusev@...nvz.org>
> 
> ---
>  net/ipv4/tcp_input.c |   78 +++++++++++++++++++++++++++++++++----------------
>  1 files changed, 52 insertions(+), 26 deletions(-)
> 
> 
> diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
> index 5119856..bbb7d88 100644
> --- a/net/ipv4/tcp_input.c
> +++ b/net/ipv4/tcp_input.c
> @@ -3841,8 +3841,28 @@ static void tcp_ofo_queue(struct sock *sk)
>  	}
>  }
>  
> +static int tcp_prune_ofo_queue(struct sock *sk);
>  static int tcp_prune_queue(struct sock *sk);
>  
> +static inline int tcp_try_rmem_schedule(struct sock *sk, unsigned int size)

minor nit, current preferred style is to not use inline for used once functions,
the compiler will do it anyway.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html