netdev - Re: [RFC] Patch to option HSO driver to the kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200804152217.25451.oliver@neukum.org>
Date:	Tue, 15 Apr 2008 22:17:21 +0200
From:	Oliver Neukum <oliver@...kum.org>
To:	Greg KH <greg@...ah.com>
Cc:	Filip Aben <f.aben@...ion.com>, linux-usb@...r.kernel.org,
	netdev@...r.kernel.org, Alan Cox <alan@...rguk.ukuu.org.uk>,
	Paulius Zaleckas <paulius.zaleckas@...tonika.lt>,
	ajb@...eresystems.co.uk
Subject: Re: [RFC] Patch to option HSO driver to the kernel

Am Dienstag, 15. April 2008 21:00:30 schrieb Greg KH:
> > Do you have a new unified patch? I'd work against that, lest we get
> > merge troubles.
> 
> Good idea :)
> 
> Here it is.

Against that one.

Change GFP_KERNEL used in interrupt and resume() to GFP_ATOMIC,
respectively GFP_NOIO

Signed-off-by: Oliver Neukum <oneukum@...e.de>

---

--- a/drivers/net/usb/hso.c	2008-04-15 21:48:10.000000000 +0200
+++ b/drivers/net/usb/hso.c	2008-04-15 21:52:48.000000000 +0200
@@ -1663,7 +1663,7 @@ static void intr_callback(struct urb *ur
 		}
 	}
 	/* Resubmit interrupt urb */
-	hso_mux_submit_intr_urb(shared_int, urb->dev, GFP_KERNEL);
+	hso_mux_submit_intr_urb(shared_int, urb->dev, GFP_ATOMIC);
 }
 
 /* called for writing to muxed serial port */
@@ -1694,7 +1694,7 @@ static int hso_std_serial_write_data(str
 			  serial->tx_data, serial->tx_data_count,
 			  hso_std_serial_write_bulk_callback, serial);
 
-	result = usb_submit_urb(serial->tx_urb, GFP_KERNEL);
+	result = usb_submit_urb(serial->tx_urb, GFP_ATOMIC);
 	if (result) {
 		dev_warn(&serial->parent->usb->dev,
 			 "Failed to submit urb - res %d\n", result);
@@ -2040,7 +2040,7 @@ static int hso_start_net_device(struct h
 
 		/* Put it out there so the device can send us stuff */
 		result = usb_submit_urb(hso_net->mux_bulk_rx_urb_pool[i],
-					GFP_KERNEL);
+					GFP_NOIO);
 		if (result)
 			dev_warn(&hso_dev->usb->dev,
 				"%s failed mux_bulk_rx_urb[%d] %d\n", __func__,
@@ -2104,7 +2104,7 @@ static int hso_start_serial_device(struc
 		if (!serial->shared_int->use_count) {
 			result =
 			    hso_mux_submit_intr_urb(serial->shared_int,
-						    hso_dev->usb, GFP_KERNEL);
+						    hso_dev->usb, GFP_ATOMIC);
 		}
 		serial->shared_int->use_count++;
 		spin_unlock_bh(&serial->shared_int->shared_int_lock);
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html