netdev - Re: [PATCH] netconsole: only set CON_PRINTBUFFER if the user specifies a netconsole

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20080415.004918.91296536.davem@davemloft.net>
Date:	Tue, 15 Apr 2008 00:49:18 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	michael@...erman.id.au
Cc:	netdev@...r.kernel.org, satyam@...radead.org, mpm@...enic.com,
	linux-kernel@...r.kernel.org, k-keiichi@...jp.nec.com
Subject: Re: [PATCH] netconsole: only set CON_PRINTBUFFER if the user
 specifies a netconsole

From: Michael Ellerman <michael@...erman.id.au>
Date: Tue, 15 Apr 2008 17:43:12 +1000 (EST)

> Since 0bcc1816188e570bde1d56a208996660f2633ae0 (netconsole: Support
> dynamic reconfiguration using configfs), the netconsole is always
> registered, regardless of whether the user actually specified a
> netconsole configuration on the command line.
> 
> However because netconsole has CON_PRINTBUFFER set, when it is
> registered it causes the printk buffer to be replayed to all consoles.
> When there is no netconsole configured this is a) pointless, and b)
> somewhat annoying for the user of the existing console.
> 
> So instead we should only set CON_PRINTBUFFER if there is a netconsole
> configuration found on the command line. This retains the existing
> behaviour if a netconsole is setup by the user, and avoids spamming
> other consoles when we're only registering for the dynamic
> netconsole case.
> 
> Signed-off-by: Michael Ellerman <michael@...erman.id.au>

That's a regression, so applied to net-2.6, thanks Michael.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html