netdev - Re: [PATCH] macb: Call phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080415015331.b6ab8963.akpm@linux-foundation.org>
Date:	Tue, 15 Apr 2008 01:53:31 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	Atsushi Nemoto <anemo@....ocn.ne.jp>,
	Haavard Skinnemoen <hskinnemoen@...el.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] macb: Call phy_disconnect on removing

On Sat, 12 Apr 2008 03:02:06 -0400 Jeff Garzik <jeff@...zik.org> wrote:

> Atsushi Nemoto wrote:
> > Call phy_disconnect() on remove routine.  Otherwise the phy timer
> > causes a kernel crash when unloading.
> > 
> > Signed-off-by: Atsushi Nemoto <anemo@....ocn.ne.jp>
> > ---
> > diff --git a/drivers/net/macb.c b/drivers/net/macb.c
> > index 1d210ed..10fcea5 100644
> > --- a/drivers/net/macb.c
> > +++ b/drivers/net/macb.c
> > @@ -1257,6 +1257,8 @@ static int __exit macb_remove(struct platform_device *pdev)
> >  
> >  	if (dev) {
> >  		bp = netdev_priv(dev);
> > +		if (bp->phy_dev)
> > +			phy_disconnect(bp->phy_dev);
> >  		mdiobus_unregister(&bp->mii_bus);
> >  		kfree(bp->mii_bus.irq);
> 
> applied
> 

Needed in 2.6.24.x as well, I think?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html