netdev - Re: [PATCH 1/7 net-2.6.26] [TIPC]: Remove inlining of reference table locking routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080415.190001.248179700.davem@davemloft.net>
Date:	Tue, 15 Apr 2008 19:00:01 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	allan.stephens@...driver.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/7 net-2.6.26] [TIPC]: Remove inlining of reference
 table locking routines

From: Allan Stephens <allan.stephens@...driver.com>
Date: Tue, 15 Apr 2008 15:43:51 -0400

> @@ -104,7 +135,7 @@ int tipc_ref_table_init(u32 requested_size, u32 start)
>  
>  void tipc_ref_table_stop(void)
>  {
> -	if (!tipc_ref_table.entries)
> +	if (unlikely(tipc_ref_table.entries == NULL))
>  		return;

Please don't mix gratuitous coding style changes with functional
changes.  It makes auditing and review harder.

And in this case I prefer the more concise "!ptr".

It also could be argued that this isn't a fast path and thus
the likely/unlikely tags are not only unnecessary, but also
likely to result in code bloat for no real gain.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html