netdev - Re: [PATCH] Discard tcp out-of-order queue if system limit is reached

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080416.000811.99314030.davem@davemloft.net>
Date:	Wed, 16 Apr 2008 00:08:11 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	andi@...stfloor.org
Cc:	vgusev@...nvz.org, kuznet@....inr.ac.ru, netdev@...r.kernel.org
Subject: Re: [PATCH] Discard tcp out-of-order queue if system limit is
 reached

From: Andi Kleen <andi@...stfloor.org>
Date: Wed, 16 Apr 2008 09:01:45 +0200

> David Miller wrote:
> > From: Vitaliy Gusev <vgusev@...nvz.org>
> > Date: Tue, 15 Apr 2008 18:54:44 +0400
> > 
> >> tcp_prune_queue() doesn't prune an out-of-order queue if socket
> >> is under rcvbuf. However even if socket is under rcvbuf but system-wide limit is
> >> reached then skb cannot be queued. It can lead to deadlock situation as any skb that
> >> fills sequence hole is dropped.
> >> So discard out-of-order queue if system-wide limit is reached.
> >>
> >> Signed-off-by: Vitaliy Gusev <vgusev@...nvz.org>
> > 
> > I applied your original patch already, so I added the following
> > relative patch.
> 
> Could you please at least update the original description to the
> one from the new patch? That one was somewhat misleading imho.

It's already a few changesets deep in my tree and it's already
pushed to kernel.org  I really don't want to have to respin my
tree and break it for all of my downstream tree developers just
to make this commit message fixup.

Sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html