netdev - Re: [PATCH] RESEND 8390: Split 8390 support into a pausing and a non pausing driver core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <48069DE1.7080301@garzik.org>
Date:	Wed, 16 Apr 2008 20:46:25 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>, akpm@...l.org
CC:	NetDev <netdev@...r.kernel.org>
Subject: Re: [PATCH] RESEND 8390: Split 8390 support into a pausing and a
 non pausing driver core

Alan Cox wrote:
> +++ linux-2.6.24-rc8-mm1/drivers/net/8390p.c	2008-01-19 15:00:41.000000000 +0000
> @@ -0,0 +1,66 @@
> +/* 8390 core for ISA devices needing bus delays */
> +
> +static const char version[] =
> +    "8390p.c:v1.10cvs 9/23/94 Donald Becker (becker@...dis.gsfc.nasa.gov)\n";
> +
> +#define ei_inb(_p)	inb(_p)
> +#define ei_outb(_v,_p)	outb(_v,_p)
> +#define ei_inb_p(_p)	inb_p(_p)
> +#define ei_outb_p(_v,_p) outb_p(_v,_p)
> +
> +#include "lib8390.c"
> +
> +int eip_open(struct net_device *dev)
> +{
> +	return __ei_open(dev);
> +}
> +
> +int eip_close(struct net_device *dev)
> +{
> +	return __ei_close(dev);
> +}
> +
> +irqreturn_t eip_interrupt(int irq, void *dev_id)
> +{
> +	return __ei_interrupt(irq, dev_id);
> +}
> +
> +#ifdef CONFIG_NET_POLL_CONTROLLER
> +void eip_poll(struct net_device *dev)
> +{
> +	__ei_poll(dev);
> +}
> +#endif
> +
> +struct net_device *__alloc_eip_netdev(int size)
> +{
> +	return ____alloc_ei_netdev(size);
> +}
> +
> +void NS8390p_init(struct net_device *dev, int startp)
> +{
> +	return __NS8390_init(dev, startp);
> +}
> +
> +EXPORT_SYMBOL(eip_open);
> +EXPORT_SYMBOL(eip_close);
> +EXPORT_SYMBOL(eip_interrupt);
> +#ifdef CONFIG_NET_POLL_CONTROLLER
> +EXPORT_SYMBOL(eip_poll);
> +#endif
> +EXPORT_SYMBOL(NS8390p_init);
> +EXPORT_SYMBOL(__alloc_eip_netdev);
> +
> +#if defined(MODULE)
> +
> +int init_module(void)
> +{
> +	return 0;
> +}
> +
> +void cleanup_module(void)
> +{
> +}
> +
> +#endif /* MODULE */
> +MODULE_LICENSE("GPL");

Now that this has seen a bit of testing, and accumulated some fix 
patches in -mm, can I get a roll-up of all those into a single patch?

Looks OK to me.  My one minor comment is that I would think the 
init_module() would be superfluous?

	Jeff


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html