netdev - Re: [PATCH 02/13] atl1: use netdev_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Apr 2008 21:33:34 -0500
From:	Jay Cliburn <jacliburn@...lsouth.net>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	Jeff Garzik <jgarzik@...ox.com>, Chris Snook <csnook@...hat.com>,
	netdev@...r.kernel.org, <atl1-devel@...ts.sourceforge.net>
Subject: Re: [PATCH 02/13] atl1: use netdev_alloc_skb

On Wed, 16 Apr 2008 16:37:29 -0700
Stephen Hemminger <shemminger@...tta.com> wrote:

> Use netdev_alloc_skb for rx buffer allocation. This sets skb->dev
> and can be overriden for NUMA machines.
> 
> Compile tested only!

Works fine.

Acked-by: Jay Cliburn <jacliburn@...lsouth.net>

> 
> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
> 
> --- a/drivers/net/atlx/atl1.c	2008-04-16 14:42:38.000000000
> -0700 +++ b/drivers/net/atlx/atl1.c	2008-04-16
> 14:44:18.000000000 -0700 @@ -1742,7 +1742,8 @@ static u16
> atl1_alloc_rx_buffers(struct 
>  		rfd_desc = ATL1_RFD_DESC(rfd_ring, rfd_next_to_use);
>  
> -		skb = dev_alloc_skb(adapter->rx_buffer_len +
> NET_IP_ALIGN);
> +		skb = netdev_alloc_skb(adapter->netdev,
> +				       adapter->rx_buffer_len +
> NET_IP_ALIGN); if (unlikely(!skb)) {
>  			/* Better luck next round */
>  			adapter->net_stats.rx_dropped++;
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html