netdev - Re: [PATCH 10/13] ixp2000: use netdev_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080417135338.GA17761@xi.wantstofly.org>
Date:	Thu, 17 Apr 2008 15:53:38 +0200
From:	Lennert Buytenhek <buytenh@...tstofly.org>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	Jeff Garzik <jgarzik@...ox.com>, netdev@...r.kernel.org
Subject: Re: [PATCH 10/13] ixp2000: use netdev_alloc_skb

On Wed, Apr 16, 2008 at 04:37:37PM -0700, Stephen Hemminger wrote:

> Use netdev_alloc_skb. This sets skb->dev and allows arch specific
> allocation.
> 
> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>

No objections, I guess..


> --- a/drivers/net/ixp2000/ixpdev.c	2008-04-07 10:36:16.000000000 -0700
> +++ b/drivers/net/ixp2000/ixpdev.c	2008-04-07 12:43:41.000000000 -0700
> @@ -108,14 +108,14 @@ static int ixpdev_rx(struct net_device *
>  		if (unlikely(!netif_running(nds[desc->channel])))
>  			goto err;
>  
> -		skb = dev_alloc_skb(desc->pkt_length + 2);
> +		skb = netdev_alloc_skb(dev, desc->pkt_length + 2);
>  		if (likely(skb != NULL)) {
>  			skb_reserve(skb, 2);
>  			skb_copy_to_linear_data(skb, buf, desc->pkt_length);
>  			skb_put(skb, desc->pkt_length);
>  			skb->protocol = eth_type_trans(skb, nds[desc->channel]);
>  
> -			skb->dev->last_rx = jiffies;
> +			dev->last_rx = jiffies;
>  
>  			netif_receive_skb(skb);
>  		}
> 
> -- 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html