netdev - Re: remove special ioctl from hso driver, replace by rfkill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <2EA56503-8726-4AF5-A383-147C3A3EC56E@holtmann.org>
Date:	Fri, 18 Apr 2008 01:28:56 +0200
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Greg KH <greg@...ah.com>
Cc:	Paulius Zaleckas <paulius.zaleckas@...tonika.lt>,
	linux-usb@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: remove special ioctl from hso driver, replace by rfkill

Hi Greg,

>>> /* called once for each interface upon device insertion */
>>> static int hso_probe(struct usb_interface *interface,
>>> 		     const struct usb_device_id *id)
>>> {
>>> 	int mux, i, if_num, port_spec;
>>> 	unsigned char port_mask;
>>> +	char *rfkn;
>>> 	struct hso_device *hso_dev = NULL;
>>> 	struct hso_shared_int *shared_int = NULL;
>>> 	struct hso_device *tmp_dev = NULL;
>>> @@ -2747,6 +2706,27 @@ static int hso_probe(struct usb_interfac
>>> 		goto exit;
>>> 	}
>>> +	hso_dev->rfkill =  
>>> rfkill_allocate(&interface_to_usbdev(interface)->dev,
>>> +				RFKILL_TYPE_WLAN);
>>
>> What will happen if rfkill is not enabled on kernel? I think HSO  
>> should
>> not depend on rfkill. Solution should be to do #ifdef  
>> CONFIG_RFKILL..?
>
> Ick, rfkill should degrade properly so that #ifdefs are not needed  
> here.
> I'll fix up rfkill.h to prevent this kind of dependancy requirement.

while you are at it, can you make sure we have a RFKILL_TYPE_WWAN for  
these cards and then use it. Using RFKILL_TYPE_WLAN for UMTS/GSM  
modems is wrong.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html