netdev - Re: [PATCH][INET 1/2]: Drop the inet_inherit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080417.231752.178453811.davem@davemloft.net>
Date:	Thu, 17 Apr 2008 23:17:52 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	xemul@...nvz.org
Cc:	netdev@...r.kernel.org, acme@...hat.com
Subject: Re: [PATCH][INET 1/2]: Drop the inet_inherit_port() call.

From: Pavel Emelyanov <xemul@...nvz.org>
Date: Thu, 17 Apr 2008 19:59:38 +0400

> As I can see from the code, two places (tcp_v6_syn_recv_sock and
> dccp_v6_request_recv_sock) that call this one already run with
> BHs disabled, so it's safe to call __inet_inherit_port there.
> 
> Besides (in case I missed smth with code review) the calltrace
> tcp_v6_syn_recv_sock
>  `- tcp_v4_syn_recv_sock
>      `- __inet_inherit_port
> and the similar for DCCP are valid, but assumes BHs to be disabled.
> 
> Signed-off-by: Pavel Emelyanov <xemul@...nvz.org>

I agree with you analysis, all of these sites have BH disabled,
patch applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html