netdev - Re: [PATCH] DM9000: __devinit/exit annotations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080418104346.GG15407@fluff.org.uk>
Date:	Fri, 18 Apr 2008 11:43:46 +0100
From:	Ben Dooks <ben-linux@...ff.org>
To:	Enrico Scholz <enrico.scholz@...ma-chemnitz.de>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] DM9000: __devinit/exit annotations

On Fri, Apr 18, 2008 at 12:02:15PM +0200, Enrico Scholz wrote:
> There were missing __dev* annotations for the dm9000_probe() 
> and dm9000_drv_remove() functions.
> 
> Signed-off-by: Enrico Scholz <enrico.scholz@...ma-chemnitz.de>
Acked-by: Ben Dooks <ben-linux@...ff.org>

>  drivers/net/dm9000.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/dm9000.c b/drivers/net/dm9000.c
> index e668b37..7bc16d2 100644
> --- a/drivers/net/dm9000.c
> +++ b/drivers/net/dm9000.c
> @@ -503,7 +503,7 @@ dm9000_release_board(struct platform_device *pdev, struct board_info *db)
>  /*
>   * Search DM9000 board, allocate space and register it
>   */
> -static int
> +static int __devinit
>  dm9000_probe(struct platform_device *pdev)
>  {
>  	struct dm9000_plat_data *pdata = pdev->dev.platform_data;
> @@ -1376,7 +1376,7 @@ dm9000_drv_resume(struct platform_device *dev)
>  	return 0;
>  }
>  
> -static int
> +static int __devexit
>  dm9000_drv_remove(struct platform_device *pdev)
>  {
>  	struct net_device *ndev = platform_get_drvdata(pdev);
> @@ -1397,7 +1397,7 @@ static struct platform_driver dm9000_driver = {
>  		.owner	 = THIS_MODULE,
>  	},
>  	.probe   = dm9000_probe,
> -	.remove  = dm9000_drv_remove,
> +	.remove  = __devexit_p(dm9000_drv_remove),
>  	.suspend = dm9000_drv_suspend,
>  	.resume  = dm9000_drv_resume,
>  };
> -- 
> 1.5.4.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Ben (ben@...ff.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html