netdev - Re: [PATCH 5/5] tun: vringfd xmit support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c0942db0804180725h88fa7d1mb8e85e5a8b0aede6@mail.gmail.com>
Date:	Fri, 18 Apr 2008 07:25:27 -0700
From:	"Ray Lee" <ray-lk@...rabbit.org>
To:	"pradeep singh rautela" <rautelap@...il.com>
Cc:	"Rusty Russell" <rusty@...tcorp.com.au>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"Max Krasnyansky" <maxk@...lcomm.com>,
	virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH 5/5] tun: vringfd xmit support.

On Fri, Apr 18, 2008 at 4:46 AM, pradeep singh rautela
<rautelap@...il.com> wrote:
>
> On Fri, Apr 18, 2008 at 10:13 AM, Rusty Russell <rusty@...tcorp.com.au> wrote:
>  >  +               /* How many pages will this take? */
>  >  +               npages = 1 + (base + len - 1)/PAGE_SIZE - base/PAGE_SIZE;
>
>  Hi Rusty,
>  A trivial suggestion, how about
>           npages = 1+(len -1)/PAGE_SIZE ?

That's not the same. In particular, his version accounts for the
fractional page at the beginning, while yours doesn't.

While it's tempting to use algebra to simplify things, it's not safe
to do so when the expression involves division over the integers. The
only care-free integer math in a computer is subtraction and ++.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html