netdev - Re: [PATCH] Removal of debug code containing deprecated calls to cli()/sti()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200804181455.m3IEtje2032231@cmf.nrl.navy.mil>
Date:	Fri, 18 Apr 2008 10:55:45 -0400
From:	"Chas Williams (CONTRACTOR)" <chas@....nrl.navy.mil>
To:	Mark Asselstine <mark.asselstine@...driver.com>
cc:	kernel-janitors@...r.kernel.org, netdev@...r.kernel.org,
	asselsm@...il.com
Subject: Re: [PATCH] Removal of debug code containing deprecated calls to cli()/sti()

In message <1208530262-8555-1-git-send-email-mark.asselstine@...driver.com>,Mar
k Asselstine writes:
>-#else /* !NS_DEBUG_SPINLOCKS */
> #define ns_grab_int_lock(card,flags) \
>         spin_lock_irqsave(&(card)->int_lock,(flags))
> #define ns_grab_res_lock(card,flags) \
>         spin_lock_irqsave(&(card)->res_lock,(flags))
> #define ns_grab_scq_lock(card,scq,flags) \
>         spin_lock_irqsave(&(scq)->lock,flags)
>-#endif /* NS_DEBUG_SPINLOCKS */

this patch should probably go one step farther and just remove these
spin_lock wrappers as well.  most people consider this bad form.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html